fix: resolve all failing tests and type errors#15
Open
stooit wants to merge 1 commit into
Open
Conversation
- Fix auth middleware case-sensitivity: 'post' → 'POST' in public methods - Fix User type field name: 'userName' → 'username' for consistency - Fix users route: replace undefined badRequest with proper Hono response - Implement pagination utility (paginate function) per test expectations - Add bun-types to tsconfig for proper type resolution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"post"→"POST") so POST requests to public endpoints aren't incorrectly rejected with 401userName→usernamein sharedUsertype to match actual usage across all packagesbadRequestreference with proper Hono JSON error responsepaginate()function per test expectations (offset/limit slicing with metadata)bun-typesto tsconfigtypesarray for properprocessandbun:testtype resolutionVerification
All 22 tests pass,
tsc --noEmitreports zero errors.Assumptions
bun-typeswas already installed innode_modules(not a new dependency)